Skip to content

Update dependencies - #43

Merged
eddietejeda merged 3 commits into
mainfrom
chore/update-deps
Sep 20, 2026
Merged

eddietejeda merged 3 commits into
mainfrom
chore/update-deps

Conversation

@eddietejeda

Copy link
Copy Markdown
Contributor
  • grafana-plugin-sdk-go v0.296.4 -> v0.296.5
  • arrow-go v18.7.0 -> v18.8.0
  • @grafana/* 13.1.4 -> 13.1.6 (13.2.x requires React 19, skipped)
  • npm update for playwright, typescript-eslint, jest, prettier, webpack, sass

- grafana-plugin-sdk-go v0.296.4 -> v0.296.5
- arrow-go v18.7.0 -> v18.8.0
- @grafana/* 13.1.4 -> 13.1.6 (13.2.x requires React 19, skipped)
- npm update for playwright, typescript-eslint, jest, prettier, webpack, sass
@eddietejeda
eddietejeda requested a review from a team as a code owner September 19, 2026 16:08
@eddietejeda
eddietejeda requested review from anoop-narang and removed request for a team September 19, 2026 16:08
claude[bot]
claude Bot previously approved these changes Sep 19, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full diff was omitted from the review prompt because of size. Review used gh pr diff for the file list and direct reads of the checkout: package.json, package-lock.json, go.mod, go.sum, src/plugin.json, and .github/workflows/.

Checks performed:

  • go.sum contains matching entries for arrow-go v18.8.0 and grafana-plugin-sdk-go v0.296.5.
  • go.mod keeps go 1.27.1, which matches the pinned go-version in .github/workflows/release.yml. CI resolves the version through go-version-file: go.mod.
  • The lockfile root block matches package.json dependency for dependency.
  • All five pinned @grafana/* packages resolve to 13.1.6 in the lockfile.
  • @grafana/e2e-selectors resolves to 13.2.0-30594044109 at top level for @grafana/plugin-e2e, and to nested 13.1.6 copies under @grafana/runtime and @grafana/ui. No source file in src/ imports @grafana/e2e-selectors, so runtime code stays on 13.1.6.

CI was still queued or in progress at review time. Build and unit test results are unverified.

Versions 3.11.2 through 3.14.0 break PanelEditPage.setVisualization on
Grafana 12.4.x (times out on the visualization picker). Verified locally
against grafana-enterprise 12.4.11: 3.11.1 passes, every later version fails.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full diff was omitted from the review prompt. Reviewed go.mod, go.sum, package.json and package-lock.json from the checkout at the head SHA, plus .github/workflows/ci.yml and src/plugin.json for version constraints.

Dependency-only change. Findings:

  • go.mod and go.sum agree: grafana-plugin-sdk-go v0.296.5 and arrow-go/v18 v18.8.0 both have h1 and go.mod hashes.
  • package.json and package-lock.json agree on all six exact-pinned @grafana/* 13.1.6 packages.
  • @grafana/plugin-e2e@3.11.1 declares engines.node: >=20 <=24. CI uses node 22 in ci.yml. No engine conflict.
  • @grafana/e2e-selectors@13.2.0-30594044109 at the lockfile root is a real dependency of plugin-e2e@3.11.1, not a stale entry. @grafana/ui and @grafana/runtime nest their own 13.1.6 copy.

CI checks were queued or in progress at review time, so build and test results are unknown.

@eddietejeda
eddietejeda merged commit 862ed5a into main Sep 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant