Repository navigation
feat(leaderboard): optimize mobile layout, navigation, and sidebar appearance - #422
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses layout issues on mobile viewports for the Leaderboard and navigation components, optimizes sidebar appearance on PC, and refines date calculations for Bangladesh.
Key Changes
Leaderboard Mobile Optimizations (Leaderboard/Index.vue):
truncatetoline-clamp-2 break-wordsto prevent medium and long names from being truncated.(i)button next to the title that opens aBaseModalexplaining the ranking algorithms, timeframes, tie-breaking rules, and privacy settings.Controller Defaults & Calendar Calculation (LeaderboardController.php):
this_weektothis_month.this_weekto start on Saturday (Carbon::now()->startOfWeek(Carbon::SATURDAY)), aligning with the Bangladeshi work/school calendar.Navigation Updates (navigation.ts):
primaryNavItemsplaced immediately before AI.Peers Page Header Fix (Peers/Index.vue):
shrink-0protection to the Leaderboard trophy button and icon to prevent squishing on mobile.Desktop Sidebar Appearance Space Saving (Navigation.tsx):