[TEMP] Buoyant v0.25.1 stats - #1
Draft
aditanase wants to merge 5 commits into
Draft
Conversation
aditanase
commented
Aug 6, 2026
| // Missing fields are read as null, but every physically present requested field must | ||
| // have a compatible type. Compare the complete requested schema so this also validates | ||
| // bookkeeping fields such as numRecords and tightBounds when they are present. | ||
| if !Self::structs_have_compatible_types(stats_struct, stats_schema, "stats_parsed") { |
Author
There was a problem hiding this comment.
assuming this is an equivalent check performed one step up in the schema?
| // statistics, ScanFile.stats remains null. | ||
| #[rstest::rstest] | ||
| #[case::default_json_only(StatsOptions::default(), false)] | ||
| #[case::default_json_only(StatsOptions::default(), true)] |
Author
There was a problem hiding this comment.
why switch the default here? can we just have checkpoint_stats_json_fallback: false as default? what breaks?
|
|
||
| fn restored_add_schema_with_parsed_columns(stats_schema: &StructType) -> SchemaRef { | ||
| let base = &*RESTORED_ADD_SCHEMA; | ||
| let add_field = base |
| unreachable!("RESTORED_ADD_SCHEMA `add` field must be a struct"); | ||
| }; | ||
| let mut inner_fields: Vec<StructField> = add_inner.fields().cloned().collect(); | ||
| inner_fields.push(StructField::nullable( |
Author
There was a problem hiding this comment.
there is some new machinery added recently - look for SchemaStructPatchBuilder and struct_patch.rs for all transforms
adragomir
force-pushed
the
buoyant-v0.25.1-stats
branch
from
August 7, 2026 08:59
f7ba255 to
7b89b7c
Compare
aditanase
force-pushed
the
buoyant-v0.25.1-stats
branch
from
August 7, 2026 10:09
7b89b7c to
44c5b98
Compare
In the respin of the patch set for distribution this change was dropped because it was manifest as a revert. Fortunately things were commented well enough that "undoing" the change is more suitable than reverting previous changes. Co-Authored-By: Mistral Devstral 2 <vibe@mistral.ai> Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
…ration manually - This is used to pass in schemas
…ats are compatible (delta-io#2998)
adragomir
force-pushed
the
buoyant-v0.25.1-stats
branch
from
August 7, 2026 13:47
44c5b98 to
9858fb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this change tested?