Skip to content

fix(auto_source): pin request budget for token-based auto-source feeds #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gildesmarais merged 2 commits into from
Aug 10, 2026
Merged

fix(auto_source): pin request budget for token-based auto-source feeds #1062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be3c300
fix(auto-source): pin request budget for token-based auto-source feeds
gildesmarais Aug 10, 2026
dff37d8
Apply suggestions from code review
gildesmarais Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/web/feeds/source_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ module Feeds
##
# Resolves static and token-backed requests into shared generator inputs.
module SourceResolver
# Request budget for token-backed auto-source feeds
AUTO_SOURCE_MAX_REQUESTS = 4

class << self
# @param feed_request [Html2rss::Web::Feeds::Contracts::Request]
# @return [Html2rss::Web::Feeds::Contracts::ResolvedSource]
Expand Down Expand Up @@ -128,7 +131,12 @@ def resolved_strategy(feed_token)
def token_generator_input(url, strategy)
global_config = LocalConfig.global
base_input = global_config.slice(:stylesheets, :headers)
base_input.merge(channel: { url: url }, auto_source: {}, strategy: strategy.to_sym)
base_input.merge(
channel: { url: url },
auto_source: {},
strategy: strategy.to_sym,
request: { max_requests: AUTO_SOURCE_MAX_REQUESTS }
)
end

# @return [String]
Expand Down
Loading