refactor: align request budgeting and renderer namespaces with gem updates - #1063
Merged
gildesmarais merged 3 commits intoAug 11, 2026
Merged
Conversation
gildesmarais
force-pushed
the
fix/auto-source-max-requests
branch
2 times, most recently
from
August 11, 2026 06:51
e1ba8cd to
4d6c2b9
Compare
gildesmarais
changed the base branch from
main
to
chore/deps-update-incl-html2rss
August 11, 2026 07:24
Remove AUTO_SOURCE_MAX_REQUESTS override in SourceResolver.token_generator_input. The web application now relies entirely on the core gem's dynamic budget slot calculations, ensuring correct scaling for sitemap scans and fallbacks. (Context: CONTEXT.md)
…paces Update Renderer to use Html2rss.defaults instead of Html2rss.configuration, and FeedBuilder::Rss::Stylesheet instead of the retired RssBuilder::Stylesheet namespace. This aligns html2rss-web with the breaking API changes introduced in html2rss gem master. (Context: CONTEXT.md)
gildesmarais
force-pushed
the
fix/auto-source-max-requests
branch
from
August 11, 2026 07:26
4d6c2b9 to
c84dfe0
Compare
gildesmarais
merged commit Aug 11, 2026
2c64ded
into
chore/deps-update-incl-html2rss
9 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AUTO_SOURCE_MAX_REQUESTS = 4inSourceResolver.token_generator_input, allowing the web application to fully rely on the core gem's new dynamic baseline request budget.Html2rss.configurationforHtml2rss.defaultsandRssBuilder::StylesheetforFeedBuilder::Rss::StylesheetinRenderer.Why
html2rssgem now dynamically calculates budget slots (including sitemap sub-fetches), making the web layer's hardcoded override obsolete.defaultsandFeedBuilder::Rss::Stylesheet) to the web renderer to maintain compatibility.Risk
Review map
Review map: whole PR is small — start at
app/web/feeds/source_resolver.rb.Validation
make ready(all linting, typescript checking, formatting, andrspectest suite passed).