Fix Windows man pages guard (os.system to sys.platform) - #1903
Open
vtino17 wants to merge 2 commits into
Open
Conversation
vtino17
force-pushed
the
fix/man-pages-windows
branch
from
July 24, 2026 08:48
9217262 to
84886e8
Compare
adnanahamed66772ndpc
pushed a commit
to adnanahamed66772ndpc/cli
that referenced
this pull request
Jul 25, 2026
os.system is a function object, comparing it to 'nt' always returns False. Changed to sys.platform == 'win32' for correct Windows detection. Closes httpie#1898, httpie#1903
Author
|
I pushed a focused regression test in commit 3a545d2. It verifies that Windows returns false before attempting to invoke man, while the implementation now uses sys.platform == "win32". The isolated Python regression check passes; CI is the cross-platform authority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1898
Problem
os.systemis a function object, so comparing it with"nt"is always false. HTTPie can therefore attempt to invokemanon Windows.Change
sys.platform == "win32"for the platform guardsubprocess.runis not calledValidation