Implement milestone payload and query builder#2284
Open
gsmet wants to merge 1 commit into
Open
Conversation
While a query builder is a bit heavy for what we actually need to do here, I favored a pattern we are using globally, and we never know what they might add to the API later. I wanted to be able to sort the milestones. Even that is extremely limited... Believe it or not, we can't sort by close dates.
11 tasks
Contributor
Author
|
hey @bitwiseman , long time no see :). I hope you're doing well. |
Contributor
Author
|
BTW, I should explain a bit why this is critical for us: I need to get the 20 latest milestones and currently we can't do it. Meaning that I'm forced to get the ~500 milestones we have in the Quarkus project and then filter them. And the GitHub API rate limiting is not exactly happy about it :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the payload for milestone... Don't know how I missed it earlier as it's quite useful.
Also allow to query the milestones with more options as it's useful to be able to sort them properly.
While a query builder is a bit heavy for what we actually need to do here, I favored a pattern we are using globally, and we never know what they might add to the API later.
I wanted to be able to sort the milestones.
Even that is extremely limited...
Believe it or not, we can't sort by close dates.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: