Fix InpaintProcessor output when no mask is provided - #14807
Closed
lindicaphxag-tech wants to merge 2 commits into
Closed
lindicaphxag-tech wants to merge 2 commits into
lindicaphxag-tech wants to merge 2 commits into
Conversation
Author
|
Closing this duplicate in favor of the earlier #14481. That PR fixes the same no-mask tuple contract, uses a precise optional-mask return type, and has broader coverage for masked and padding-crop paths. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14470.
InpaintProcessor.preprocessreturns three values when a mask is present, but the no-mask early return only returned the processed image. Direct callers that rely on the tuple contract then fail while unpacking the result.The no-mask path now returns the processed image,
Nonefor the mask, and empty overlay metadata. The return annotation and a focused regression test cover that path.Validation run locally:
git diff --checkThe targeted pytest command could not start in this checkout because Pillow is not installed locally. CI remains the source of truth for the full dependency environment.