Skip to content

nix-builder: skip nvvm copy in ptxas override when absent - #954

Open
drbh wants to merge 1 commit into
mainfrom
fix-ptxas-override-cuda13-nvvm
Open

drbh wants to merge 1 commit into
mainfrom
fix-ptxas-override-cuda13-nvvm

Conversation

@drbh

@drbh drbh commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

since cuda 13, nvvm ships in a separate libnvvm package, so cuda_nvcc has no nvvm/bin. when ptxasVersion points at a 13.x release, the glob in the ptxas override expands to nothing and the cuda_nvcc build fails:

cuda13.0-cuda_nvcc> cp: missing destination file operand after '/nix/store/...-cuda13.0-cuda_nvcc-13.0.88/nvvm/bin/'

this pr only copies nvvm/bin when it exists. no version defaults change, this just unblocks kernel-specific ptxas overrides like huggingface/kernels-community#1285 (failing job: https://github.com/huggingface/kernels-community/actions/runs/40942703764/job/123690362546)

this is the nvvm part of #952, which was closed in favor of the kernel-specific override. it was tested locally there: cuda 13.0 nvcc with ptxas 13.4 on aarch64-linux, and cuda 13.2 nvcc with ptxas 13.4 on x86_64-linux both build

Since CUDA 13, nvvm is shipped in a separate libnvvm package, so
cuda_nvcc has no nvvm/bin. The glob then expands to nothing and cp
fails with a missing destination operand, breaking any build that
sets ptxasVersion to a 13.x release.
drbh added a commit to huggingface/kernels-community that referenced this pull request Oct 30, 2026
Temporary pin to torch-2.15.0-rc5 plus huggingface/kernels#954, so the
13.x ptxas overrides can build.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant