Repository navigation
Sync chat's vendored PwC MCP skill to pwc-mcp 0.2.7 - #517
Merged
Merged
Conversation
Vendor huggingface/pwc-cli mcp_server/SKILL.md at a2fc9d0 (PR #28). Papers not indexed on Papers With Code now come back with in_catalog=false, a note, and available_at links, and the skill tells the agent to cite those sources rather than a Papers With Code paper page. The new skill also directs the agent to get_paper_evaluations, which the live MCP server already exposes, so allowlist it in the gateway and Pi worker and map `pwc paper evaluations` to it; otherwise the prompt would name a tool the chat cannot call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76df4c5. Configure here.
The catalog overlay and state-of-the-art procedure now describe pwc_get_paper_info as compact by default, with include_resources for artifacts, pwc_get_paper_evaluations for benchmark results, and in_catalog=false papers cited via available_at. adaptMcpSkill drops the upstream advice to pass cursor "next" on a first read_paper, which chat resolves from a saved token and rejects when none exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
mcp_server/SKILL.mdat a2fc9d0 (Use the public-metadata API for papers outside the catalog pwc-cli#28, pwc-mcp 0.2.7) intobackend/chat_sandbox_worker/PWC_MCP_SKILL.md, and updates the pin comment inmcp_research_prompt.ts.in_catalog: false, anote, andavailable_atlinks (via Serve public metadata for papers outside the catalog #508's public-metadata endpoint), and the agent must cite those sources rather than a PwC paper page. It also brings the 0.2.1–0.2.7 tool docs (hybrid default search, paginatedget_benchmark,searchon task/method lists, etc.).get_paper_evaluations. The live MCP server already exposes that tool (confirmed withtools/liston paperswithcode.co/mcp), but the chat allowlist didn't include it, so the prompt would have named a tool the chat can't call. This PR adds it to the gatewayTOOL_NAMESand PiPWC_MCP_TOOLS(20 → 21 tools), mapspwc paper evaluationsto it, and updates the catalog-usage prompt anddocs/chat-pwc-mcp.md. Because discovery fails closed, this must not ship to an environment whose MCP server lacksget_paper_evaluations; production already has it.sync-pwc-cli-skill.ymlonly syncsPWC_CLI_SKILL.md, andtest_pi_prompt_assets.pycompares the published file against the vendored one, not against a fixed hash.Tests
pytest backend/tests/chat_gateway/test_pwc_mcp.py backend/tests/test_pi_prompt_assets.py backend/tests/chat_sandbox/test_prompts_and_catalogs.py: 29 passed.chat_gateway/,external_pi/test_runtime.py,paper_edits/test_policy.py), 32 tests fail intest_turn_fence.pyandexternal_pi/test_runtime.py. The same set fails on a cleanorigin/maincheckout in this environment.npm test: 199 pass. 2 tests fail ("native MCP …" web search), and they fail the same way onorigin/main.adaptMcpSkillrenderspwc_get_paper_evaluationsand theavailable_atguidance.Chat-related: do not merge or deploy without explicit approval.
🤖 Generated with Claude Code
Note
Medium Risk
Expands the fixed MCP allowlist and prompt contract; discovery fails closed if an environment’s MCP server lacks
get_paper_evaluations, and off-catalog citation rules change agent behavior for missing papers.Overview
Updates the vendored PwC MCP skill to pwc-mcp v0.2.7 (new upstream pin in
mcp_research_prompt.ts) so chat prompts match current tool behavior: hybrid default search, paginatedget_benchmark,searchon task/method lists, softer handling of unknown leaderboard metrics, and richer paper lookup (short titles, off-catalogin_catalog: falsewithavailable_atlinks instead of PwC paper URLs).get_paper_evaluationsis added to the gateway and Pi tool allowlists (20 → 21 tools) with CLI mapping and catalog-usage text, so agents are not instructed to call a tool discovery would reject. Prompt adaptation drops upstream guidance to pass"next"before the firstread_paperread, since chat resolves cursors differently.Docs and tests reflect the new tool count and prompt strings (
available_at,pwc_get_paper_evaluations).Reviewed by Cursor Bugbot for commit 60b5700. Bugbot is set up for automated code reviews on this repo. Configure here.