refactor: split PTO operation family declarations - #1233
Open
mouliangyu wants to merge 4 commits into
Open
Conversation
mouliangyu
force-pushed
the
codex/ir-component-migration-design
branch
from
August 12, 2026 08:30
11f784b to
37bb50f
Compare
mouliangyu
force-pushed
the
codex/ir-component-migration-design
branch
from
August 12, 2026 09:45
37bb50f to
e7950c9
Compare
mouliangyu
force-pushed
the
codex/ir-component-migration-design
branch
from
August 12, 2026 15:33
e7950c9 to
5b44c8c
Compare
mouliangyu
marked this pull request as ready for review
August 13, 2026 03:09
mouliangyu
force-pushed
the
codex/ir-component-migration-design
branch
2 times, most recently
from
August 13, 2026 07:55
a5fc3cb to
d7bbda6
Compare
mouliangyu
force-pushed
the
codex/ir-component-migration-design
branch
from
August 14, 2026 01:21
d7bbda6 to
6006846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
当前 PTO 的 operation ODS 入口把 PTO Base、PTO Tile、VMI、VPTO 和 UB operation 全部串在一个
PTOOps.td中,generated public declarations 也只能作为一个整体使用。这样无法形成稳定的 semantic family ownership,也让后续 generated definition、registration 和 handwritten semantics 的迁移缺少可依赖的 public 边界。本 PR 的范围
本 PR 实现设计中的第一个迁移步骤:为每个 semantic family 建立真实的 ODS owner 和 generated public declaration。它不修改 IR 语法或 operation 语义,也不提前拆 generated definitions、registration 或
PTO.cpp中的手写实现。修改内容
PTOBase、PTO Tile、VMI、VPTO、VPTO UB。VPTOOpCommon.td,集中放置跨 VPTO family 共享的 type constraints 和 operation base classes。.h.inc,并提供独立 public header。PTOTile.h、VPTO.h和PTO.h保留为兼容 aggregate;aggregate 只转发 family headers,不重复展开同一份 generated declarations。PTOOps.td、PTOTileOps.td、VPTOOps.td继续作为 aggregate TableGen 入口。pto-ir-family-ownership-design.md,明确第一步覆盖所有 semantic family;generated definitions/registration 和 handwritten semantics 仍按后续步骤迁移。兼容性与完整性
166 -> 166,无遗漏、无新增、无重复;279 -> 279,无遗漏、无新增、无重复;VPTOUbOps.tdaggregate 继续提供。PTOOps.td、PTOOps.h.inc和PTOOps.cpp.inc作为兼容入口和历史实现过渡层。验证
git diff --checkcmake --build build --target PTOOpsIncGen -j 8cmake --build build --target PTOIR -j 1PTO.h独立 include 语法检查