CI: move additional simulator scenes to daily sweep - #1823
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthroughSelected simulator tests now use manual-execution markers for ChangesSimulator execution policy
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This change only adjusts simulator test selection while retaining representative Per-PR coverage and daily execution for migrated cases; no actionable merge-blocking risk remains after normal checks and review. Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
--manual excludefor Per-PR CI and rely on the existing Daily workflow's--manual includeto retain every migrated case.Cases moved from Per-PR Sim
prepare_new_identity_after_start_then_runon each architecturescope_deadlock,heap_ring_deadlock,flow_control_deadlock,dep_pool_overflow,invalid_args,require_sync_start_invalid,async_wait_overflowexplicit_fatalandasync_completion_invalidTestSpmdSyncStartStress::Case1TestHostBuildGraphWideDispatch::TwoThreadsep_dispatch_combineon both Sim lanesdomain_rank_map, P3 overlappinggroup_reservation, and the A2/A3 L3 allreduce demodomain_rank_mapand P3 overlappinggroup_reservationep_dispatch_combineand Allreduce One-phase P2n_64_no_chain,n_200_single_overflow,n_391_two_overflown_65_single_overflowDenseFanoutFaninSingleDummyAutoDepandDummyExplicitDepBarriermixed_subtask_overflow,unbound_owner_read, andunbound_owner_writezero_block_numINVALID_ARGSpropagation. Per-PR keeps one end-to-end invalid-input smoke; Daily keeps the branch-specific matrix.spmd_basic, mixed AIC+AIV multiblock, ordinary sync-start, sync-start mix/spill, edge, and early-dispatch pathsmulti_chip_dispatchep_dispatch_combineDefaultCoverage policy
manualannotations are platform-scoped where the case also supports Onboard, so this PR only changesa2a3simanda5simselection.manual_mode: include.Observed timing impact
The complete fresh-CI run at current head
0cf94764passed all four Sim lanes. To reduce corpus drift, the comparison below uses run 31687370652 from the same day as the nearest pre-change reference and compares only theRun pytest scene testsstep; toolchain and package setup are excluded.The four-lane pytest reduction is 7m20s of runner time (about 33%). Both A5 lanes improved by more than two minutes and A2/A3 Ubuntu improved by 1m50s. The slowest pytest lane fell from 5m48s to 4m35s, so the observed critical-path improvement is 1m13s; A2/A3 macOS remains the variable long tail. The spread confirms that simulator contention and limited parallel scheduling make the wall-time benefit non-linear; migrated-case count should not be interpreted as additive duration.
Measured run 31695897393
Validation
python -m pytest tests/ut/py/test_manual_selection.py tests/ut/py/test_scene_level_selection.py -q: 36 passed.--manual exclude: 78/266 items retained;--manual only: 79/266 items selected, including pre-existing Daily coverage.--manual exclude: 52/266 items retained;--manual only: 72/266 items selected, including pre-existing Daily coverage.--max-parallel 4) smoke passed all 52 selected items; its warm-cache 1m09s wall time is validation only, not used as the CI estimate.git diff --check upstream/main...HEAD: passed.