Skip to content

lua: consolidate query helpers and standardize DID validation - #36

Merged
Kzoeps merged 2 commits into
mainfrom
lua/consolidate-query-helpers
Oct 7, 2026
Merged

Kzoeps merged 2 commits into
mainfrom
lua/consolidate-query-helpers

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Standardize manifest-listed query handlers on the broad shared DID validator, preserving non-DID URI constraints and existing error mappings.
  • Reuse record-view and list helpers; extract narrow datetime validation and a bounded createdAt SQL helper while preserving serialization, cursor, and ordering behavior.
  • Remove redundant handler-status assertions while retaining expected endpoint rosters and behavioral coverage.
  • Regenerate Lua bundles, update consumer guidance, and add a patch Changeset.

Validation

  • pnpm check: 313 API unit tests and 17 endpoint-explorer tests passed; generated freshness, JavaScript/Lua lint, and types passed.
  • pnpm build and pnpm changeset:status passed.
  • Independent adversarial review completed; follow-up query-binding assertions and consumer guidance were re-reviewed.
  • Controlled Lua comparisons confirmed all four timestamp SQL expressions match the previous implementation byte-for-byte.
  • HTTP runtime validation is handled by CI.

@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 05c8420

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/hypercerts-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
api-endpoints Skipped Skipped Oct 7, 2026 9:41am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 101 files, which is 1 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fed10f59-1ea5-4a88-8c60-c117eb84fe25
📥 Commits

Reviewing files that changed from the base of the PR and between f648abd and 05c8420.

📒 Files selected for processing (101)
  • .agents/skills/hypercerts-api/references/reliability.md
  • .changeset/broad-did-validation.md
  • api/lua/endpoints/getAcknowledgement.lua
  • api/lua/endpoints/getContribution.lua
  • api/lua/endpoints/getContributorInformation.lua
  • api/lua/endpoints/getEvmLink.lua
  • api/lua/endpoints/getFeature.lua
  • api/lua/endpoints/getMeasurement.lua
  • api/lua/endpoints/getOrganization.lua
  • api/lua/endpoints/getOrganizations.lua
  • api/lua/endpoints/getProfile.lua
  • api/lua/endpoints/getProfiles.lua
  • api/lua/endpoints/getRights.lua
  • api/lua/endpoints/getVocabTag.lua
  • api/lua/endpoints/getWorkscopeTag.lua
  • api/lua/endpoints/listAcknowledgements.lua
  • api/lua/endpoints/listActivities.lua
  • api/lua/endpoints/listCollections.lua
  • api/lua/endpoints/listContributions.lua
  • api/lua/endpoints/listContributorInformation.lua
  • api/lua/endpoints/listEvmLinks.lua
  • api/lua/endpoints/listFeatures.lua
  • api/lua/endpoints/listMeasurements.lua
  • api/lua/endpoints/listOrganizations.lua
  • api/lua/endpoints/listProfiles.lua
  • api/lua/endpoints/listRights.lua
  • api/lua/endpoints/listVocabTags.lua
  • api/lua/endpoints/listWorkscopeTags.lua
  • api/lua/endpoints/searchActivities.lua
  • api/lua/endpoints/searchCollections.lua
  • api/lua/endpoints/searchOrganizations.lua
  • api/lua/endpoints/searchProfiles.lua
  • api/lua/shared/acknowledgement.lua
  • api/lua/shared/acknowledgementList.lua
  • api/lua/shared/activityList.lua
  • api/lua/shared/collectionList.lua
  • api/lua/shared/contribution.lua
  • api/lua/shared/contributorInformationValidation.lua
  • api/lua/shared/createdAtSort.lua
  • api/lua/shared/datetimeValidation.lua
  • api/lua/shared/evmLinkIdentifier.lua
  • api/lua/shared/featureValidation.lua
  • api/lua/shared/listValidation.lua
  • api/lua/shared/measurementQuery.lua
  • api/lua/shared/organization.lua
  • api/lua/shared/organizationList.lua
  • api/lua/shared/profile.lua
  • api/lua/shared/profileList.lua
  • api/lua/shared/profileLookup.lua
  • api/lua/shared/rightsIdentifier.lua
  • api/lua/shared/vocabTagValidation.lua
  • api/lua/shared/workscopeTag.lua
  • api/lua/shared/workscopeTagList.lua
  • api/lua/src/getOrganizations.lua
  • api/lua/src/getProfiles.lua
  • api/lua/src/listContributions.lua
  • api/lua/src/listContributorInformation.lua
  • api/lua/src/listEvmLinks.lua
  • api/lua/src/listFeatures.lua
  • api/lua/src/listMeasurements.lua
  • api/lua/src/listRights.lua
  • api/lua/src/listVocabTags.lua
  • api/modules/acknowledgements/manifest.json
  • api/modules/activity/manifest.json
  • api/modules/actor-follow/manifest.json
  • api/modules/badge-definitions/manifest.json
  • api/modules/badge-queries/manifest.json
  • api/modules/collection/manifest.json
  • api/modules/context-attachments/manifest.json
  • api/modules/context-evaluation/manifest.json
  • api/modules/context-measurements/manifest.json
  • api/modules/contribution/manifest.json
  • api/modules/contributor-information/manifest.json
  • api/modules/entity-follow/manifest.json
  • api/modules/evm-links/manifest.json
  • api/modules/features/manifest.json
  • api/modules/funding/manifest.json
  • api/modules/location/manifest.json
  • api/modules/organization/manifest.json
  • api/modules/profile/manifest.json
  • api/modules/recent-follows/manifest.json
  • api/modules/rights/manifest.json
  • api/modules/vocab/manifest.json
  • api/modules/workscope-tags/manifest.json
  • api/tests/http/getContributorInformation.http.test.js
  • api/tests/unit/context-measurements/measurements.lua
  • api/tests/unit/endpoints/rights-edge-lua.test.js
  • api/tests/unit/endpoints/rights-lua.test.js
  • api/tests/unit/feature.test.js
  • api/tests/unit/lua/recentFollows.test.lua
  • api/tests/unit/tooling/acknowledgement.test.js
  • api/tests/unit/tooling/activity.test.js
  • api/tests/unit/tooling/collection.test.js
  • api/tests/unit/tooling/contributions.test.js
  • api/tests/unit/tooling/evm-links.test.js
  • api/tests/unit/tooling/getContributorInformation.test.js
  • api/tests/unit/tooling/listContributorInformation.test.js
  • api/tests/unit/tooling/organization.test.js
  • api/tests/unit/tooling/profile.test.js
  • api/tests/unit/tooling/vocab-tags.test.js
  • api/tests/unit/workscopeTags.test.lua

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@Kzoeps
Kzoeps merged commit 9018f66 into main Oct 7, 2026
7 of 8 checks passed
@Kzoeps
Kzoeps deleted the lua/consolidate-query-helpers branch October 7, 2026 09:48
@github-actions github-actions Bot mentioned this pull request Oct 7, 2026

This branch was previously deployed

1 inactive deployment
Preview — 05c8420a Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant