Update to tracing 0.1.36 - #305
Open
kayabaNerve wants to merge 2 commits into
Open
Conversation
`tracing 0.1.35` pulls in `tracing-core 0.1.27` which adopted `once_cell` over `lazy_static`, fixing some macro issues I had when I tried to compile with minimal dependencies. `tracing 0.1.36` is explicitly guaranteed to compile with `-Zminimal-versions`. `hyper-util` explicitly does not compile against the minimal version of `tracing 0.1` as it uses misc features added between `0.1 and 0.x`. `0.1.36` is within `hyper-util`'s MSRV bound. This version of `tracing` is sufficient for all my experiments I did with `-Zminimal-versions`, hence why I PR it here, but I can't confirm this is sufficient for all environments, the exact latest version of `hyper-util`, and in the future, a workflow confirming `hyper-util` compiles with `-Zminimal-versions` would be valuable. I also encountered issues with how `tower 0.4` wouldn't compile against `tower-layer 0.3` (solely `tower-layer 0.3.1`), but `tower` is no longer an explicit dependency of `hyper-util`.
https://github.com/tokio-rs/tokio/blob/master/tokio/CHANGELOG.md#1130-october-29-2021 added `watch::Sender::send_replace`, as used in `src/client/legacy/connect/capture.rs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracing 0.1.35pulls intracing-core 0.1.27which adoptedonce_celloverlazy_static, fixing some macro issues I had when I tried to compile with minimal dependencies.tracing 0.1.36is explicitly guaranteed to compile with-Zminimal-versions.hyper-utilexplicitly does not compile against the minimal version oftracing 0.1as it uses misc features added between0.1 and 0.x.0.1.36is withinhyper-util's MSRV bound.This version of
tracingis sufficient for all my experiments I did with-Zminimal-versions, hence why I PR it here, but I can't confirm this is sufficient for all environments, the exact latest version ofhyper-util, and in the future, a workflow confirminghyper-utilcompiles with-Zminimal-versionswould be valuable. I also encountered issues with howtower 0.4wouldn't compile againsttower-layer 0.3(solelytower-layer 0.3.1), buttoweris no longer an explicit dependency ofhyper-util.