fix: AGENTIC licence line + a2ml-validate-action repin - #48
Conversation
…, #669) 1. The AGENTIC.a2ml agent-constraint line "Never use AGPL license (...)" contradicts LICENCE-POLICY.adoc Rules 3 (co-developed), 4 (network services) and 5 (games), which MANDATE AGPL-3.0-or-later - and 144 copies named the retired PMPL-1.0-or-later. Replaced with a pointer to the policy plus the A2 no-automated-licence-edits rule, hardcoding no licence so it cannot go stale again. Same wording as the template fix in rsr-template-repo#45; owner-ruled sweep (2026-08-27). 2. Any workflow pinning hyperpolymath/a2ml-validate-action at 59145c7d or e558e79200 is repinned to 6ac6416f. Those two SHAs never existed: the repo itself was only created 2026-08-28 and populated by subtree split from a2ml/actions/validate (286 files, history preserved). The old pins could never resolve and made lockfile generation impossible. Direct push per owner ruling of 2026-08-28. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR is incomplete as it lacks the implementation for the 'a2ml-validate-action' repin mentioned in the title and description. While the changes to the licensing guidelines are present and technically up to standards according to Codacy, they contain a minor path inconsistency that should be addressed for reliability. The acceptance criteria regarding the action repin remain unfulfilled.
About this PR
- The PR description indicates an intent to repin the 'a2ml-validate-action' to a valid commit SHA, but this change is missing from the code. Please ensure the repository repin is included as part of this PR.
1 comment outside of the diff
[REDACTED:HIGH_ENTROPY]
line 25⚪ LOW RISK
Suggestion: The reference to the license policy document is inconsistent. Line 26 uses the full pathstandards/LICENCE-POLICY.adoc, while line 25 omits the directory. Providing the full path consistently helps automated tools and AI agents locate the file reliably.# sweep (standards/LICENCE-POLICY.adoc A2). New files get correct SPDX from birth.
Test suggestions
- Verify that the licensing text correctly reflects the mandates of Rules 1, 2, 3, 4, and 5 of the LICENCE-POLICY.adoc.
- Verify that the 'a2ml-validate-action' uses a valid, existing commit SHA from its new repository.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the licensing text correctly reflects the mandates of Rules 1, 2, 3, 4, and 5 of the LICENCE-POLICY.adoc.
2. Verify that the 'a2ml-validate-action' uses a valid, existing commit SHA from its new repository.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
1 participant
Ruleset refused a direct push, so this lands by PR. Two mechanical fixes, owner-ruled:
Never use AGPL license (…)contradictsLICENCE-POLICY.adocRules 3/4/5 (which mandate AGPL for their scopes). Replaced with the policy pointer used inrsr-template-repo#45. Seestandards#646.a2ml-validate-actionrepin — the previously-pinned SHAs never existed; the repo was only created 2026-08-28 (split froma2ml/actions/validate, history preserved). Repinned to its real HEAD. Seestandards#669.🤖 Generated with Claude Code