fix: AGENTIC licence line + a2ml-validate-action repin - #199
Merged
Conversation
…, #669) 1. The AGENTIC.a2ml agent-constraint line "Never use AGPL license (...)" contradicts LICENCE-POLICY.adoc Rules 3 (co-developed), 4 (network services) and 5 (games), which MANDATE AGPL-3.0-or-later - and 144 copies named the retired PMPL-1.0-or-later. Replaced with a pointer to the policy plus the A2 no-automated-licence-edits rule, hardcoding no licence so it cannot go stale again. Same wording as the template fix in rsr-template-repo#45; owner-ruled sweep (2026-08-27). 2. Any workflow pinning hyperpolymath/a2ml-validate-action at 59145c7d or e558e79200 is repinned to 6ac6416f. Those two SHAs never existed: the repo itself was only created 2026-08-28 and populated by subtree split from a2ml/actions/validate (286 files, history preserved). The old pins could never resolve and made lockfile generation impossible. Direct push per owner ruling of 2026-08-28. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (86)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
While this PR successfully updates the licensing guidance in AGENTIC.a2ml files, it is currently incomplete relative to its description. The repinning of a2ml-validate-action (standards#669) mentioned in the title is missing from the code changes.
Furthermore, there is an inconsistency in how the LICENCE-POLICY.adoc is referenced; one line uses a shorthand path while another uses a full repository-relative path. This inconsistency should be resolved to ensure reliability for AI agents and downstream automation. No automated tests were provided to verify the formatting of the modified .a2ml files.
About this PR
- The PR implementation is incomplete. The 'a2ml-validate-action repin' mentioned in the title and description is missing from the submitted changes. Please ensure the repository repin is included as intended.
Test suggestions
- Verify that the prohibited AGPL instruction is removed from all AGENTIC.a2ml files.
- Verify that the new license guidance text correctly maps Rules 1-5 to their respective licenses as specified in the description.
- Verify that a2ml-validate-action is repinned to the correct HEAD SHA.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the prohibited AGPL instruction is removed from all AGENTIC.a2ml files.
2. Verify that the new license guidance text correctly maps Rules 1-5 to their respective licenses as specified in the description.
3. Verify that a2ml-validate-action is repinned to the correct HEAD SHA.
Low confidence findings
- The PR includes no automated tests or verification scripts to ensure the license policy changes in the .a2ml files are correctly formatted for downstream consumption.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| # - Never place state files in repository root (must be in .machine_readable/) | ||
| # - Never use AGPL license (use PMPL-1.0-or-later) | ||
| # - Never relicense an existing file, and never run an automated licence | ||
| # sweep (LICENCE-POLICY.adoc A2). New files get correct SPDX from birth. |
Contributor
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: The licensing policy reference is inconsistent: line 25 omits the 'standards/' prefix, while line 26 includes it. In a monorepo with deep subdirectories, AI agents may fail to resolve the shorthand path. Try running the following prompt in your coding agent: > In all AGENTIC.a2ml files, update the licensing rule to consistently use 'standards/LICENCE-POLICY.adoc' for both the sweep reference and the read reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruleset refused a direct push, so this lands by PR. Two mechanical fixes, owner-ruled:
Never use AGPL license (…)contradictsLICENCE-POLICY.adocRules 3/4/5 (which mandate AGPL for their scopes). Replaced with the policy pointer used inrsr-template-repo#45. Seestandards#646.a2ml-validate-actionrepin — the previously-pinned SHAs never existed; the repo was only created 2026-08-28 (split froma2ml/actions/validate, history preserved). Repinned to its real HEAD. Seestandards#669.🤖 Generated with Claude Code