chore: fill or remove RSR template placeholders - #6
Merged
Conversation
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.
Three kinds of change, no invention:
The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.
Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.
PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
A previous `just init` copied already-filled templates out of
squisher-corpus, so the identity landed in the BODY of the security
policy, not only in the legend block. burble/SECURITY.md directed
vulnerability reports to hyperpolymath/squisher-corpus, and 50 other
repositories did the same.
This is not cosmetic. A researcher who follows the policy files their
report against a repository that has nothing to do with the code they
were looking at, and the maintainer of the project actually affected
never sees it.
Repointed at this repository, derived from its own git remote. Also
rewords the prose that says "replace {{PLACEHOLDER}} tokens"; that is
documentation of the mechanism rather than an unfilled field, but the
OpenSSF gate greps for the token and cannot tell the difference -- the
same trap the Slavia Mustfile already records for its own probe.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. CI failed: CI failed because the CodeQL GitHub Action references an invalid commit SHA that cannot be downloaded.OverviewA single configuration failure occurred in CI due to an unresolvable GitHub Actions workflow dependency. FailuresUnresolvable CodeQL Action Version (confidence: high)
Summary
Code Review ✅ ApprovedFills and removes RSR template placeholders to satisfy openssf-compliance.yml checks and repoints 51 security policies to the correct repository. No issues found.
Tip Comment OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssf-compliance.ymlfails when any of the thirteen files it checks still contains a{{PLACEHOLDER}}token. This clears them, with no invention.TEMPLATE INSTRUCTIONS (delete this block before publishing)comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.https://github.com/<user>.gpgreturns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previousjust initcopied already-filled templates out ofsquisher-corpus, so 51 repositories directed vulnerability reports tohyperpolymath/squisher-corpus— a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.