Reuse audio meter controls and stop unloaded timers - #534
Draft
iamfatness wants to merge 1 commit into
Draft
iamfatness wants to merge 1 commit into
iamfatness wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio meters replaced their entire XAML subtree on every level update and 33 ms decay tick. They now retain a bounded pool of segments and scale marks, updating brushes and geometry in place. Unloaded meters cannot restart their timers, and unload detaches the timer callback.
Related to #513. This reduces lifetime churn but does not claim to fix the unexplained idle fail-fast: the owner's correction establishes that ordinary finalizer-thread releases and forced GC can succeed. The issue should remain open. Framework versions are unchanged.
Validation: Release shell build passed; all 1,477 existing WinUI tests passed. A separate windowless WinUI executable passed 10,000 updates with stable control identities, responsive layout/scale checks, mute coloring, unloaded timer suppression, and a full GC followed by successful rendering. Added that executable to Windows CI. Live Loaded/Unloaded navigation and idle-crash validation remain outstanding.
Records the owner's next-work order in the backlog. Detailed evidence and reproduction commands are in docs/xaml-lifetime-hardening-2026-09-14.md.