IBX-11413: Use design-system dropdown component - #1902
Open
tischsoic wants to merge 37 commits into
Open
Conversation
dew326
approved these changes
May 15, 2026
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
2 times, most recently
from
May 28, 2026 07:18
4f5430d to
8193ee5
Compare
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
June 2, 2026 06:42
8193ee5 to
c41218f
Compare
albozek
reviewed
Jun 3, 2026
KamilSznajdrowicz
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
June 8, 2026 13:37
c41218f to
3f5f8e4
Compare
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
June 9, 2026 12:01
3f5f8e4 to
1f7c8fa
Compare
|
KamilSznajdrowicz
force-pushed
the
IBX-11413-use-ds-dropdown
branch
2 times, most recently
from
June 12, 2026 09:18
cbc8bf3 to
1fe890c
Compare
|
albozek
approved these changes
Jun 16, 2026
dew326
reviewed
Jun 17, 2026
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/ibexa/design-system-twig" |
Contributor
There was a problem hiding this comment.
This is probably not needed.
dew326
approved these changes
Jun 17, 2026
tischsoic
force-pushed
the
ds-development
branch
2 times, most recently
from
July 15, 2026 10:58
f474be6 to
ed8b2e2
Compare
tischsoic
force-pushed
the
ds-development
branch
from
July 23, 2026 09:53
6ea5c67 to
1f8c649
Compare
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
2 times, most recently
from
July 29, 2026 07:44
98c70f4 to
b7d4154
Compare
GrabowskiM
approved these changes
Jul 31, 2026
| import { | ||
| DropdownMultiInput, | ||
| DropdownSingleInput, | ||
| } from '../../../../../../../design-system-twig/src/bundle/Resources/public/ts/components/dropdown'; |
Contributor
There was a problem hiding this comment.
Don't we have alias for this bundle?
If we don't we probably should. :D
| }; | ||
| const attachFieldDefinitionNodeEvents = (fieldNode, { targetContainer }) => { | ||
| const initDropdown = (dropdownContainer) => { | ||
| const dropdownAlreadyInitialized = !!ibexa.helpers.objectInstances.getInstance(dropdownContainer); |
Contributor
There was a problem hiding this comment.
Not for this PR, but considering we're introducing TS in 6.0, do we want to create separate hasInstance in order not to cast it to bool each time?
| const clearSection = (event) => { | ||
| sectionSelect[0].selected = true; | ||
| if (sectionSelect) { | ||
| sectionSelect[0].selected = true; |
Contributor
There was a problem hiding this comment.
Suggested change
| sectionSelect[0].selected = true; | |
| sectionSelect?.[0].selected = true; |
nitpick from optional chaining apostle ;)
Contributor
Author
There was a problem hiding this comment.
conditional chaining cannot be used in assignment :)
OstafinL
approved these changes
Aug 3, 2026
This reverts commit 9eaad2c.
The order inputs in relation_base.html.twig use ids-input-text markup for styling only, without the actions block and clear button. The global init_components.ts picked them up and InputTextInput threw on the missing elements, aborting the rest of the layout bundle (ibexa.core.Backdrop and everything after it) on edit pages with existing relations. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
IBX-12038 replaced both selectors with the same .ids-btn--extra-actions class, leaving pages whose trigger buttons still use .ibexa-btn--extra-actions (site-context, customer templates) unable to open the extra actions panel. Restore the dual selector. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Wrap over-length lines flagged by prettier in files touched by the DS dropdown migration; no logic changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tischsoic
force-pushed
the
IBX-11413-use-ds-dropdown
branch
from
August 4, 2026 05:58
61b9622 to
bf44414
Compare
Address review remark: replace the deep relative design-system-twig import with the existing @ibexa-design-system alias, as used elsewhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The trans wrapper contained a Translator.trans(key, ...) call with a non-literal key, which crashed the JS translation extractor (and the TranslationTest integration suite) on Peast Identifier::getValue(). Passing the Translator object as the context value removes the call site entirely; DS components invoke it method-style, so binding and behavior are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The DS dropdown wrapper introduces the ibexa.dropdown.placeholder.all key in the ibexa_design_system_twig domain; ship its extracted xliff so the translation test passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: