Keep tool caches out of the release ZIP - #3
Merged
Conversation
The release workflow runs PHPCS and PHPUnit immediately before staging the distributable, and rsync does not honour .gitignore, so .phpunit.result.cache was copied into the v2.0.0 ZIP. Harmless but it should not ship. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow runs PHPCS and PHPUnit immediately before staging the distributable, and
rsyncdoes not honour.gitignore— so.phpunit.result.cachewas copied into the v2.0.0 ZIP.Harmless (an inert ~200 byte cache file) but it shouldn't ship. Adding it and
.phpcs.cacheto.distignore.I'll re-cut the v2.0.0 tag and release after this merges, so the published artifact is clean. The current release has zero downloads.
🤖 Generated with Claude Code