Do not apply cancelled decompilation output - #4165
Merged
Merged
Conversation
The token was checked before the output was collected, but collecting the text and waiting for the UI callback both take time. A cancel landing in that window - the assembly was removed from the list, the user selected something else - still let the finished output overwrite whatever state the tab had been put into since. Assisted-by: Claude:claude-opus-5[1m]:Claude Code Assisted-by: OpenCode:openai/gpt-5.5:OpenCode
siegfriedpammer
force-pushed
the
fix/do-not-apply-cancelled-decompilation
branch
from
September 21, 2026 15:52
856944c to
5de9631
Compare
siegfriedpammer
deleted the
fix/do-not-apply-cancelled-decompilation
branch
September 26, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cancellation can arrive after decompilation output has been collected but before the UI-thread apply callback runs. Re-check the token on the UI thread so stale output does not overwrite the tab state selected after cancellation.
Verification: not run separately; split from #4157.
This PR description was written by an AI agent (OpenCode gpt-5.5) working under @siegfriedpammer's direction.