Repository navigation
Add the EnergyPlus adoption caller, and the command that lists an adopted release - #27
Merged
Merged
Conversation
…pted release The caller pins the reusable adoption workflow of idfkit-conformance at governance-2026.25. The command adds the release to the table of releases and to the tutorial's printed list of schema versions, refuses a release the installed idfkit does not list, and changes nothing on a second run.
Contributor
|
Docs preview for this PR is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Purpose
This pull request adds the EnergyPlus adoption caller for this project, together with the command that the roster's
release-rowsstep runs. It is part of spec 012 (specs/012-energyplus-release-adoptionin idfkit-unification). The steps and the gate are declared foridfkit-developersingovernance/energyplus.tomlof idfkit-conformance atgovernance-2026.25.2. Changes
.github/workflows/adopt-energyplus.yml: calls the reusableadopt-energyplus.ymlof idfkit-conformance atgovernance-2026.25, and states the tag a second time asgovernance_level. It holds no logic. It grantscontents: writeandpull-requests: writeonly. It never merges, publishes or releases.scripts/adopt_release.py: lists an adopted release in the two places that enumerate every release:docs/reference/versions.md, where the release takes the first open pair of cells, or a new row when the table has none;docs/getting-started/core-tutorial.ipynb, where the release's tuple is appended.The command refuses a release that the installed
idfkitdoes not list, and a second run changes nothing. Exit codes: 0 when both places list the release, 1 when the release cannot be listed, 2 when the arguments are wrong.tests/test_adopt_release.py: 6 tests against the committed pages, covering the open row, a full table, the appended tuple, idempotence, the refusal and a missing table.3. Verification
make checkpasses, with pyright reporting 0 errors, and the 6 new tests pass.caller_problemsatgovernance-2026.25) reports no problem.26.1.0exits 0 and reports that both places already list it.26.2.0exits 1, because the installedidfkitdoes not list it.@idfkit/schemasthat carries the release, so a dispatch before then reportswaiting.