Repository navigation
Commit only pyproject.toml and uv.lock from the idfkit bump - #30
Merged
Merged
Conversation
The bump workflow checks idfkit-conformance out into governance/ and let create-pull-request commit the whole tree, so the checkout was committed as a gitlink with no .gitmodules entry (#29). The workflow now names the two files it writes.
Contributor
|
Docs preview for this PR is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Defect
bump-idfkit.ymlchecks idfkit-conformance out intogovernance/, inside the working tree, and calledpeter-evans/create-pull-request@v7withoutadd-paths. The action commits every change in the tree, so the nested checkout was committed as a gitlink:governance, mode160000, pointing at idfkit-conformance2b96631, with no.gitmodulesentry. Any lateractions/checkoutof a commit holding it fails withfatal: No url found for submodule path 'governance' in .gitmodules.The open bump pull request #29 carries that gitlink. It has been removed from #29's branch separately, so #29 can merge; this change stops the next bump from adding it. idfkit-plugin merged the same defect into
mainand has been failing every checkout since (idfkit/idfkit-plugin#23).2. Change
create-pull-requestreceivesadd-pathslistingpyproject.tomlanduv.lock, the two files the workflow writes (the dependency with[tool.idfkit.library] level, thenuv lock).