Skip to content

Pin the language server the plugin delivers: idfkit-lsp 0.2.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelduchesne merged 2 commits into from
Sep 11, 2026
Merged

Pin the language server the plugin delivers: idfkit-lsp 0.2.0 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c985f9f
Pin the language server the plugin delivers: idfkit-lsp 0.2.0
samuelduchesne Sep 11, 2026
81b58c8
Keep .lsp.json compact, and say in AGENTS.md that the language server…
samuelduchesne Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .lsp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"idfkit": {
"command": "uvx",
"args": ["--from", "idfkit-lsp", "python", "-m", "idfkit_lsp"],
"args": ["--from", "idfkit-lsp==0.2.0", "--prerelease=allow", "python", "-m", "idfkit_lsp"],
"extensionToLanguage": {
".py": "python"
}
Expand Down
12 changes: 7 additions & 5 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ idfkit package, not here.
| Slash commands | `commands/*.md` | Yes |
| Context hooks | `hooks/hooks.json`, `scripts/*.sh` | Yes |
| MCP server wiring | `.mcp.json` (`uvx idfkit-mcp@<version>`, pinned) | Yes, by review |
| LSP wiring | `.lsp.json` (`uvx --from idfkit-lsp`, unpinned until idfkit-lsp publishes) | Yes, by review |
| LSP wiring | `.lsp.json` (`uvx --from idfkit-lsp==<version> --prerelease=allow`, pinned) | Yes, by review |
| Claude plugin / marketplace | `.claude-plugin/plugin.json`, `.claude-plugin/marketplace.json` | Yes |

## Discovery contract
Expand Down Expand Up @@ -71,10 +71,12 @@ depending on `idfkit-mcp` and `idfkit-lsp`, and adopting in wave 2 after them.
version: an unpinned `uvx idfkit-mcp` runs whatever is newest on the day, so a
release would reach users unreviewed. The user still types no version; the
level is committed here. The idfkit level follows from that release's own pin.
- **`.lsp.json` cannot be pinned yet.** idfkit-lsp has never been published to
PyPI, so today that entry resolves nothing on a clean machine. The register
records it as a `not-yet` lag on idfkit/idfkit-plugin#17. Pin it as
`uvx --from idfkit-lsp==X.Y.Z` in the change that follows the first release.
- **`.lsp.json` pins idfkit-lsp exactly** (`--from idfkit-lsp==X.Y.Z`), on the
same terms as `.mcp.json`. `--prerelease=allow` follows the pin while
idfkit-lsp depends on a pre-release of idfkit, because uv installs a
pre-release of an indirect dependency only when told to. Keep the flag after
the pin, so the level stays at `args[1]` where the consumer register reads it,
and drop it once idfkit-lsp depends on a stable idfkit.
- **Both files are CODEOWNERS-reviewed**, because changing either changes what
every user runs.
- **The self-check.** The `consumer-register` job in `tests.yml` calls
Expand Down
Loading