Repository navigation
Record adoptions in the register with an app token, not a personal one - #20
Merged
Merged
Conversation
The bump workflow dispatches record-adoption.yml in idfkit-conformance to close a lag or record a decline. It now mints that token from the organisation's GitHub App, scoped to idfkit-conformance and valid for an hour, instead of reading CONFORMANCE_DISPATCH_TOKEN. Without APP_ID and APP_PRIVATE_KEY it behaves as it did without the old token: a decline fails, and a lag-closing adoption puts the command in its pull request body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
CONFORMANCE_DISPATCH_TOKEN, a personal access token, with a token minted by the organisation's GitHub App, idfkit-bot, for the one repository this workflow dispatches into: idfkit-conformance, whererecord-adoption.ymlopens the paired register pull request.The maintainer chose the app over personal tokens. It acts as the app rather than as a person, each token lasts an hour instead of months, and nothing is tied to anyone's account.
Secrets now needed:
APP_ID(idfkit-bot, app id 3703965) andAPP_PRIVATE_KEY. Until they are set, this workflow behaves exactly as it did whileCONFORMANCE_DISPATCH_TOKENwas unset:actionlint is clean.
mainrequires code-owner review, and GitHub never lets an author approve their own pull request, so merging this one needs the administrator bypass.