Repository navigation
Remove the committed governance gitlink, and commit only .mcp.json from the bump - #24
Merged
Merged
Conversation
…om the bump The bump workflow checked idfkit-conformance out into governance/ and let create-pull-request commit the whole tree, so #23 committed that checkout as a gitlink with no .gitmodules entry. Every checkout of main has failed since. The gitlink is removed, and the workflow names the one file it writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Defect
mainat81d148a(#23) holds a gitlinkgovernance. Since then every job that checks outmainfails, for example tests run 38585240356.bump-idfkit.ymlchecks idfkit-conformance out intogovernance/, inside the working tree, and calledpeter-evans/create-pull-request@v7withoutadd-paths. The action commits every change in the tree, so the nested checkout was committed as a gitlink:governance, mode160000, pointing at idfkit-conformance2b96631, with no.gitmodulesentry. Any lateractions/checkoutof a commit holding it fails withfatal: No url found for submodule path 'governance' in .gitmodules.2. Change
governancegitlink from the index (git rm --cached); nothing else in the tree changes.create-pull-requestadd-paths: .mcp.json, the one file the workflow writes..lsp.jsonis moved by a person in the pull request, not by the bot.3. Same defect elsewhere
idfkit-developers and idfkit-mcp-deployment use the same pattern and receive the same workflow fix in their own pull requests; their open bump PRs (#29, #8) have the gitlink removed from their branches before merge.