Repository navigation
test: ask for a precise count in test_count_batiment_vendee to avoid a bbox fallback - #61
Merged
Merged
Conversation
…a bbox fallback (refs #42) With ignfab/geocontext#216, the too large Vendée geometry is rejected and the error message suggests a bbox filter, which overcounts (~1 111 000 buildings). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #42
Changes
test_count_batiment_vendee.py: the question now asks for a precise count on the exact department footprint:"Combien y a-t-il de bâtiments dans le département de la Vendée ? Je veux un comptage précis sur l'emprise exacte du département, pas une approximation."
Motivation
With ignfab/geocontext#216, the too large
ADMINEXPRESS-COG.LATEST:departementgeometry is rejected and the error message suggests either the-CARTO-PElayer or a bbox filter. With the original question, the model followed the bbox hint and answered 1 111 470 buildings (neighbouring departments included).Testing
Against a local geocontext built from ignfab/geocontext#216, with claude-haiku-4-5: passed 2/2, answer 854 362. The model still tries the bbox first, then switches to
ADMINEXPRESS-COG-CARTO-PE.LATEST:departement.Not done
SKIP_TEST_COUNT_BATIMENT_VENDEE) until feat: limit too big filters geocontext#216 is released.🤖 Generated with Claude Code