fix(release): drop deprecated Homebrew cask syntax in tap template - #30
Merged
Merged
Conversation
Homebrew now warns on the generated cask:
- the `verified:` parameter in the `url` stanza is deprecated in favor
of the default URL verification behaviour; the release URLs share the
homepage domain, so it can simply be removed
- `postflight` blocks are deprecated in favor of `postflight_steps`,
using the new install-steps DSL (`run` with the `{{staged_path}}`
template token, guarded by `on_macos`)
The tap casks were already patched directly in imfing/homebrew-tap;
this keeps future releases from regenerating the deprecated syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew started warning on the generated cask:
This updates the cask template in the release workflow so future releases generate warning-free casks:
verified:from theurlstanza — the release URLs are on the same domain as the homepage, so the default URL verification behaviour covers it.postflight→postflight_steps— uses the new install-steps DSL:runwith the{{staged_path}}template token, guarded byon_macos(replacing theif OS.mac?check).The current casks in imfing/homebrew-tap were already patched directly (imfing/homebrew-tap@1543d1c); the new syntax parses cleanly with
brew infolocally. This PR only affects casks generated by future releases.