Skip to content

feat!: refactor to rest - #403

Merged
cowan-macady merged 1 commit into
masterfrom
refactoring-to-rest-v2
Aug 4, 2026
Merged

feat!: refactor to rest#403
cowan-macady merged 1 commit into
masterfrom
refactoring-to-rest-v2

Conversation

@cowan-macady

@cowan-macady cowan-macady commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

implement ENG-9279

refactor to rest endpoints

integration tests will be added in next PR

Copilot AI lite review requested due to automatic review settings August 4, 2026 15:31
@cowan-macady
cowan-macady requested review from a team as code owners August 4, 2026 15:31
@cowan-macady
cowan-macady requested a review from krispetkov August 4, 2026 15:31
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@cowan-macady
cowan-macady requested review from chahalarora and removed request for krispetkov August 4, 2026 15:32
@socket-security

socket-security Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedcoverage@​7.15.2 ⏵ 7.15.395 +1100100100100
Addedanyio@​4.14.297100100100100
Updatedcffi@​2.1.0 ⏵ 2.1.197100100100100
Updatedcryptography@​49.0.0 ⏵ 50.0.0100100 +16100100100
Addedtyping-inspection@​0.4.2100100100100100
Addedruff@​0.16.1100100100100100
Addedhttpcore@​1.0.9100100100100100
Addedpydantic-core@​2.46.4100100100100100
Addedpytest-asyncio@​1.4.0100100100100100
Addedannotated-types@​0.8.0100100100100100
Addedh11@​0.16.0100100100100100
Addedrespx@​0.23.1100100100100100
Addedhttpx@​0.28.1100100100100100

View full report

@deepsource-io

deepsource-io Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 187fe96...b8a645f on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Secrets Aug 4, 2026 6:15p.m. Review ↗
Python Aug 4, 2026 6:15p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@cowan-macady
cowan-macady force-pushed the refactoring-to-rest-v2 branch from 1850ed6 to 4aa3b39 Compare August 4, 2026 15:42
Copilot AI review requested due to automatic review settings August 4, 2026 15:42
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 4, 2026 15:57
@cowan-macady
cowan-macady force-pushed the refactoring-to-rest-v2 branch from 4aa3b39 to ce01d16 Compare August 4, 2026 15:57
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 4, 2026 16:04
@cowan-macady
cowan-macady force-pushed the refactoring-to-rest-v2 branch from ce01d16 to 354c152 Compare August 4, 2026 16:04
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

chahalarora
chahalarora reviewed Aug 4, 2026
View reviewed changes
Comment thread indykite_sdk/entity_matching/client.py Outdated
__all__ = ["EntityMatchingClient"]

#: Step statuses that mean the step is no longer running.
FINAL_STATUSES = frozenset({"SUCCESS", "ERROR", "FAILURE", "FAILED"})

@chahalarora chahalarora Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: FINAL_STATUSES doesn't match the API's documented status format

PipelineStatus.entity_matching_status is documented (entity_matching/models.py:57) as returning values like STATUS_SUCCESS / STATUS_PENDING

@cowan-macady cowan-macady Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated (was the old gRPC
)

@cowan-macady
feat!: refactor to rest
b8a645f 
implement [ENG-9279]
Copilot AI review requested due to automatic review settings August 4, 2026 18:14
@cowan-macady
cowan-macady force-pushed the refactoring-to-rest-v2 branch from 354c152 to b8a645f Compare August 4, 2026 18:14
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@cowan-macady
cowan-macady merged commit 3cb6906 into master Aug 4, 2026
14 checks passed
@cowan-macady
cowan-macady deleted the refactoring-to-rest-v2 branch August 4, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@chahalarora chahalarora chahalarora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cowan-macady @chahalarora