Skip to content

chore(deps): remove vulnerable analyzer templates and gate critical audits #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infeng merged 1 commit into from
Sep 9, 2026
Merged

chore(deps): remove vulnerable analyzer templates and gate critical audits #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ jobs:
- name: Build SSR fixture
run: npm run build:ssr

- name: Check critical dependency advisories
run: npm run audit:critical

- name: Check package contents
run: npm pack --dry-run
6 changes: 6 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ npm run verify

The verification command runs unit tests, lint, the library build, the browser demo build, the SSR fixture build, and an npm package dry run. A change is not complete until this command succeeds.

`npm run audit:critical` checks both dependency trees against the public npm
advisory service and is part of `verify` and CI. It requires network access and
fails on critical advisories; lower severities remain a tracked maintenance
backlog. Resolve failures from their dependency paths, without force-upgrading
unrelated toolchains or weakening the audit threshold.

For a focused change, run the smallest relevant command while iterating, then finish with `npm run verify`:

- `npm test -- --runInBand`: unit tests and coverage.
Expand Down
194 changes: 102 additions & 92 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
"check:ssr-hydration": "node scripts/check-ssr-hydration.js",
"check:package-export": "node scripts/check-package-export.js",
"check:multipart": "node scripts/check-multipart.js",
"audit:critical": "npm audit --audit-level=critical && npm --prefix ssr-test audit --audit-level=critical",
"build:analyze": "ANALYZE=true webpack --config webpack.config.prop.js",
"doc": "webpack --config webpack.config.doc.js",
"verify": "npm test -- --runInBand && npm run lint && npm run build && npm run check:package-export && npm run doc && npm run build:ssr && npm run check:ssr-hydration && npm run check:multipart && npm pack --dry-run",
"verify": "npm test -- --runInBand && npm run lint && npm run build && npm run check:package-export && npm run doc && npm run build:ssr && npm run check:ssr-hydration && npm run check:multipart && npm run audit:critical && npm pack --dry-run",
"pub": "npm publish",
"prepublishOnly": "npm run build"
},
Expand Down Expand Up @@ -85,7 +86,7 @@
"typescript": "^3.6.4",
"url-loader": "^2.2.0",
"webpack": "^4.47.0",
"webpack-bundle-analyzer": "^3.6.0",
"webpack-bundle-analyzer": "^4.10.2",
"webpack-chain": "^6.0.0",
"webpack-cli": "^3.3.9",
"webpack-dev-server": "^3.8.2",
Expand Down