feat(sql): Move eventfilter into preprocessing - #3928
Merged
Conversation
awildturtok
force-pushed
the
feature/ai-eventfilter-into-preprocessing
branch
4 times, most recently
from
August 4, 2026 09:53
b16b760 to
0c9f06b
Compare
Co-Authored-By: CODEX
awildturtok
force-pushed
the
feature/ai-eventfilter-into-preprocessing
branch
from
August 4, 2026 10:25
0c9f06b to
7c0982c
Compare
awildturtok
changed the title
thoniTUB
approved these changes
Aug 10, 2026
Comment on lines
+35
to
+42
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.function.Predicate; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.jooq.impl.DSL.*; | ||
|
|
| .conversionContext(conversionContext) | ||
| .build(); | ||
| .ids(ids) | ||
| .connector(connectorTables.getLabel()) |
Collaborator
There was a problem hiding this comment.
Ich weiß nicht ob Name hier möglich ist, aber Label sieht im Converter falsch aus
Suggested change
| .connector(connectorTables.getLabel()) | |
| .connector(connectorTables.getName()) |
Collaborator
Author
There was a problem hiding this comment.
Das ist ein programmatisch erstelltes label und nicht das label des connectors. Lustigerweise kommt es aber von context.getNameGenerator().conceptConnectorName :D
Ich bennene das ganze mal um
Comment on lines
+358
to
+361
| 1. When converting a concept and creating the `PREPROCESSING` CTE, which is the starting point of each concept | ||
| conversion, we join the concepts or respectively the connectors table with the stratification table for all IDs from | ||
| the stratification table. | ||
| the stratification table. In the same step, we filter all entries where the stratification range and the subject's | ||
| validity date do not overlap. This is important because we only want to compute aggregations for overlapping ranges. |
Collaborator
There was a problem hiding this comment.
Du brauchst hier jetzt keine Aufzählung mehr zu machen, wenn es nur noch einen einzelnen Schritt gibt
awildturtok
enabled auto-merge (squash)
August 10, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.