Repository navigation
fix(self-update): remove the download temp dir after replacing eget - #60
Merged
Merged
Conversation
Update created an eget-self-update-* directory for every run and never removed it, so they piled up in the temp dir (inherelab#59). Clean it up once the replace has finished or failed. Keep it when the replace is deferred, since the Windows helper script still moves the extracted binary after eget exits. Fixes inherelab#59
inhere
self-requested a review
October 6, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eget update --selfdownloads into a fresheget-self-update-*directory under the system temp dir, but nothing ever removed it, so one directory piled up per self-update (#59).SelfUpdateService.Updatenow removes that directory when it returns, whether the update succeeded or failed. The one exception is a deferred replace (Windows): there the helper script still moves the extracted binary after eget exits, so the directory has to stay.Test:
TestSelfUpdateCleansTempDirAfterReplaceruns a full update with a fake installer and replacer and checks that the temp dir is gone afterwards.go test ./internal/app/passes.Fixes #59