Repository navigation
comments-view: list every comment except ranges that collapsed to empty - #89
Open
paulsonnentag wants to merge 4 commits into
Open
paulsonnentag wants to merge 4 commits into
paulsonnentag wants to merge 4 commits into
Conversation
Threads targeting a sub-doc path (e.g. a notebook cell) have no text range, so they were filtered out of the sidebar. Only hide a thread when all its targets are text ranges whose text was deleted.
Collaborator
✅ Patchwork glance readyhttps://patchwork-preview-89--patchwork-base.netlify.appPatchwork from |
chee
previously approved these changes
Oct 13, 2026
…elections Hovering a thread card puts its targets in the focus doc's `highlight`, so the view showing them can emphasise them. A selection on a sub-doc (e.g. a notebook cell) now selects threads targeting it, not only overlapping text ranges.
Primary, secondary and inactive cards differed only by shadow. In the panel, the selected thread now gets an accent border, ring and tint, overlapping threads a softer accent border, and inactive ones an accent hint on hover. Threads embedded on their own keep the old look.
The sidebar sets data-thread-state on each <patchwork-view>, but the thread tool is handed the view's inner content element, so it never saw the attribute and every thread fell back to primary (all highlighted, all showing Resolve/Reply).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads targeting a sub-doc path (e.g. a notebook cell) have no text range, so they were filtered out of the sidebar. Only hide a thread when all its targets are text ranges whose text was deleted.