Skip to content

Size and complexity lint growth warns during feature work (h3-studio#899) #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apedintensor merged 1 commit into from
Oct 31, 2026
Merged

Size and complexity lint growth warns during feature work (h3-studio#899) #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion studio-app/tools/check-lint.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,17 @@ if (process.argv.includes('--update')) {
process.exit(0);
}
const baseline = JSON.parse(readFileSync(baselineFile, 'utf8'));
// Owner 2026-10-31: size and complexity only warn while a feature is built; it is
// refactored afterwards (h3-studio#899). Correctness rules still fail.
const STRUCTURE = new Set(['complexity', 'max-lines-per-function']);
const grown = [];
for (const [rule, files] of Object.entries(counts))
for (const [file, n] of Object.entries(files)) {
const was = baseline.files[rule]?.[file] || 0;
if (n > was) grown.push(`${file}: ${rule} ${n} (was ${was})`);
if (n <= was) continue;
const line = `${file}: ${rule} ${n} (was ${was})`;
if (STRUCTURE.has(rule)) console.warn('warn (refactor later) ' + line);
else grown.push(line);
}
if (grown.length) {
for (const line of grown) console.error(line);
Expand Down
Loading