Repository navigation
Let people on credits export a film - #370
Merged
Merged
Conversation
The server removes the dollar estimate for non-admins under credits, and the film dialog treated that as an unknown quote, so Start stayed disabled. The sound choice also showed a saved option when none was saved, and never showed the clips option after picking it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under credits the server removes
cost_microusdfor non-admins (user_estimate), andFilmRunViewandcontroller.confirmboth required it, so people on credits saw "can't estimate" with Start disabled.filmQuoted: a credits number is a quote; dollars only apply when there is no credits field.Tested locally: full
npm test911 pass, lint, build.