build: commit Gemfile.lock and add dependabot - #18
Merged
Merged
Conversation
Resolution was fresh on every run, so two checkouts a week apart could run different rspec-core or redis versions, and dependency drift never showed up in a diff. The lock pins the default resolution. The matrix still resolves past it — each leg pins its own combination through the gemspec env hooks — so build.yml drops the lock before installing. Without that, bundler re-resolves anyway and rewrites it on every run. Lint keeps the lock and fails if bundler had to rewrite it, which catches a version bump that forgot to regenerate it. Dependabot covers both ecosystems: github-actions to move the SHA pins, which otherwise freeze permanently, and bundler, which only becomes useful now that there is a lockfile to bump. refs DE-1818 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution was fresh on every run, so two checkouts a week apart could run different
rspec-coreorredisversions, and dependency drift never showed up in a diff. Committing the lock pins the default resolution.The matrix still resolves past it — each leg pins its own combination through the gemspec env hooks — so
build.ymldrops the lock before installing. I confirmed that without this, bundler re-resolves anyway and silently rewrites the lock every run (rspec-core 3.13.6→3.12.3), so the explicitrmjust makes the existing behaviour honest.Lint keeps the lock and fails if bundler had to rewrite it, which catches a version bump that forgot to regenerate it. Worth noting: because the Gemfile uses
gemspec, the lock records rspecq's own version, so a version bump must include the regenerated lock.Dependabot covers both ecosystems —
github-actionsto move the SHA pins, which otherwise freeze permanently, andbundler, which only becomes useful now that there's a lockfile to bump.bundle config set frozen truelater. Frozen mode plus env-pinned gemspec deps breaks the matrix outright — I hit exactly that while testing.refs DE-1818
Test plan
Gemfile.lock is up to datecheck passes on CI — confirms setup-ruby installs the bundler fromBUNDLED WITHrather than churning the line🤖 Generated with Claude Code