Skip to content

support model_type == "inkling_mm_model" - #2214

Open
xin3he wants to merge 10 commits into
mainfrom
xinhe/8-22
Open

support model_type == "inkling_mm_model"#2214
xin3he wants to merge 10 commits into
mainfrom
xinhe/8-22

Conversation

@xin3he

@xin3he xin3he commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request introduces improved support for handling fused 3-D Mixture-of-Experts (MoE) expert weights, especially for architectures whose inference engines require these weights to remain fused (such as inkling_mm_model). The main changes ensure that such fused tensors are preserved and quantized appropriately, rather than being split into per-expert 2-D tensors.

Fused MoE expert weight support:

  • Added a new set _KEEP_FUSED_EXPERT_MODEL_TYPES in missing_tensors.py to identify model types that require fused expert tensors to be preserved, and updated split_fused_expert_tensors to skip splitting for these types. [1] [2] [3] [4]
  • Introduced _is_moe_fused_expert_weight and _quantize_moe_fused_expert_weight in model_free_utils.py to detect and quantize fused 3-D expert weights in place using MXFP quantization, preserving the fused layout.
  • Updated _quantize_single_tensor to use the new quantization logic for fused MoE weights.
  • Adjusted _process_shard to correctly track and process fused 3-D MoE expert weights, ensuring they are not mistakenly excluded from quantization.

These changes improve compatibility with architectures that require fused expert weights, prevent errors during quantization, and ensure correct handling for advanced MoE models.

Type of Change

New feature

Related Issues

Fixes or relates to #

Checklist Before Submitting

  • My code has been tested locally.
  • Documentation has been updated as needed.
  • New or updated tests are included where applicable.
  • The CUDA CI has passed. You can trigger it by commenting /azp run Unit-Test-CUDA-AutoRound.

Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xin3he

xin3he commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

…ation

Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

…paths and generic projection names

Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xin3he

xin3he commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants