[UR][L0] Fix throwing exceptions - #23026
Open
KFilipek wants to merge 2 commits into
Open
Conversation
KFilipek
force-pushed
the
1251-exceptions
branch
from
August 25, 2026 12:22
52cdfd6 to
657a440
Compare
KFilipek
force-pushed
the
1251-exceptions
branch
2 times, most recently
from
August 25, 2026 12:39
646d0f2 to
431b6ef
Compare
kswiecicki
reviewed
Aug 25, 2026
| ur::level_zero::v1::urMemRelease( | ||
| reinterpret_cast<::ur_mem_handle_t>(SubBuffer->Parent)); | ||
| } catch (...) { | ||
| // Ignore any errors during destruction |
Contributor
There was a problem hiding this comment.
Could you add a UR_LOG_SAFE log about the failed memory release in UR buffer destructor.
KFilipek
force-pushed
the
1251-exceptions
branch
from
August 26, 2026 08:42
431b6ef to
36bc6eb
Compare
KFilipek
force-pushed
the
1251-exceptions
branch
from
August 26, 2026 08:43
36bc6eb to
8d34769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Coverity exception-related issues.