[SYCL][CMake] Enable LLVM_LINK_LLVM_DYLIB builds of the SYCL toolchain - #23052
Open
koparasy wants to merge 1 commit into
Open
[SYCL][CMake] Enable LLVM_LINK_LLVM_DYLIB builds of the SYCL toolchain#23052koparasy wants to merge 1 commit into
koparasy wants to merge 1 commit into
Conversation
Contributor
Author
|
@vmustya for your verifier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable building the SYCL toolchain with -DLLVM_LINK_LLVM_DYLIB=ON
(-DCLANG_LINK_CLANG_DYLIB=ON), previously unsupported.
This is a needed change to allow clang plugins to be loaded during compilation
of sycl code.
Under dylib, tools link libLLVM.so instead of the LLVM component
libraries and so don't inherit their INTERFACE properties. Fixes:
LLVMSPIRVLib dependency on LLVMGenXIntrinsics that formed an illegal
cross-dylib cycle (LLVM -> SYCLLowerIR -> GenXIntrinsics -> SPIRVLib
-> LLVM) and broke CMake configuration.
spirv-to-ir-wrapper and sycl-jit (matching llvm-spirv).
LLVMGenXIntrinsics INTERFACE include directories explicitly.
All changes are guarded by LLVM_LINK_LLVM_DYLIB; static builds are
unchanged.