[XPTIFW][CMake] Set SONAME to the library major version (#23031) - #23058
Merged
KornevNikita merged 1 commit intoAug 31, 2026
Merged
Conversation
xptifw sets only the library VERSION (1.0.1) and no SOVERSION, so the generated SONAME is libxptifw.so.1.0.1. This churns the SONAME on every point release, forcing needless rebuilds of consumers that link against libxptifw, and it does not follow the usual shared-library convention. Set SOVERSION to the project major version so the SONAME becomes libxptifw.so.1, which stays stable across the 1.x series. This is something I ran into while packaging v7.0.0 of the compiler for Ubuntu 26.10. I have this change in a patch for the packaging but wanted to go ahead and contribute it so ideally we don't need to maintain the patch for future releases. cc @dvrogozh @sarnex
KornevNikita
temporarily deployed
to
WindowsCILock
August 31, 2026 11:43 — with
GitHub Actions
Inactive
Contributor
Author
KornevNikita
temporarily deployed
to
WindowsCILock
August 31, 2026 12:23 — with
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
August 31, 2026 12:23 — with
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
August 31, 2026 12:23 — with
GitHub Actions
Inactive
dm-vodopyanov
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xptifw sets only the library VERSION (1.0.1) and no SOVERSION, so the generated SONAME is libxptifw.so.1.0.1. This churns the SONAME on every point release, forcing needless rebuilds of consumers that link against libxptifw, and it does not follow the usual shared-library convention.
Set SOVERSION to the project major version so the SONAME becomes libxptifw.so.1, which stays stable across the 1.x series.
This is something I ran into while packaging v7.0.0 of the compiler for Ubuntu 26.10. I have this change in a patch for the packaging but wanted to go ahead and contribute it so ideally we don't need to maintain the patch for future releases.
cc @dvrogozh @sarnex
cherry-pick: 9dbd3e7