feat: add merchant onboarding field definitions API#2214
Open
mirunagherman wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
package: wallet/backend
DaevMithran
reviewed
Jun 27, 2026
| try { | ||
| const formDefinition = | ||
| await this.terminalService.getOnboardingFormDefinition() | ||
| res.status(200).json(formDefinition) |
There was a problem hiding this comment.
Suggested change
| res.status(200).json(formDefinition) | |
| res.status(200).json(toSuccessResponse(formDefinition)) |
DaevMithran
reviewed
Jun 27, 2026
|
|
||
| // Terminal | ||
| router.get( | ||
| '/terminals/onboarding', |
There was a problem hiding this comment.
Non-blocking:
Should this endpoint be public? or protected by a custom terminal auth middleware or a rate limiter if it's left public.
Contributor
There was a problem hiding this comment.
Agreed with Daev. This endpoint should not be public. It is called only from Merchant API - We can pass some API key (uuid) in the request head for example and you can check if the header is correct - need to discuss about this.
Does testnet wallet has proper HTTP signatures (RFC 9421)?
DaevMithran
requested changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes
field_definitionsandoptionstables to store form configuration