docs(codeql): regenerate triage + clusters against post-merge GHAS state - #61
Merged
Merged
Conversation
After merging PRs #51-#60 the open alert count dropped from 610 (the original Aug 9 snapshot) to 25. Re-runs: - scripts/fetch-gh-code-scanning-alerts.py → 25 open alerts - scripts/generate-clusters.py → 3 critical/high clusters - scripts/generate-triage.py → 9 false-positive / 16 fix Remaining alerts (25): - js/xss-through-dom (14) — first-party delivery views; the .text()/ .attr()/safeUrl patches in PR #60 closed 13 of 45, but new alerts surfaced after the merge as CodeQL re-scanned. - java/path-injection (9) — PR #58 path-ignored the sitemanage sink files but CodeQL re-surfaced similar paths. - js/incomplete-sanitization (2) — new alerts in cui/widgets/app/app.viewmodel.js (lines shifted from 87 to 88 after the /g-flag fix). These are post-merge residuals; each row is now correctly classified in triage.md (9 false-positive under existing path-ignores, 16 fix with no linked_pr). clusters.md rows updated to mark them as '8.1.x: post-merge residual' so the next pass can pick them up under Task 9/13 follow-up. Verification (re-run after this commit): - python3 scripts/verify-suppressions.py PASS - python3 scripts/verify-triage-inventory.py PASS (25 == 25) - python3 scripts/verify-valid-fixes.py PASS JDK 1.8.0 compatible. No CHANGELOG.md entry per AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After merging PRs #51–#60 the open CodeQL alert count dropped from
610 (the original Aug 9 snapshot) to 25. Re-runs:
scripts/fetch-gh-code-scanning-alerts.py→ 25 open alertsscripts/generate-clusters.py→ 3 critical/high clustersscripts/generate-triage.py→ 9 false-positive / 16 fixRemaining alerts (25)
js/xss-through-dom.text()/.attr()/safeUrl patches in PR #60 closed 13 of 45, but new alerts surfaced)java/path-injectionjs/incomplete-sanitizationcui/widgets/app/app.viewmodel.jsline shifted from 87 to 88 after the/g-flag fix in PR #57)Disposition in
triage.mdlinked_pr(need follow-up Task 9/13 work)Validation
python3 scripts/verify-suppressions.py— PASSpython3 scripts/verify-triage-inventory.py— PASS (25 == 25)python3 scripts/verify-valid-fixes.py— PASSJDK 1.8.0 compatible. No CHANGELOG.md entry per AGENTS.md.