fix(firestore): fail iOS transaction timeout without SDK retry - #9303
Draft
russellwheatley wants to merge 3 commits into
Draft
fix(firestore): fail iOS transaction timeout without SDK retry#9303russellwheatley wants to merge 3 commits into
russellwheatley wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9303 +/- ##
============================================
+ Coverage 69.49% 69.52% +0.04%
- Complexity 2129 2130 +1
============================================
Files 439 439
Lines 25472 25475 +3
Branches 4251 4252 +1
============================================
+ Hits 17700 17710 +10
+ Misses 6365 6361 -4
+ Partials 1407 1404 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
A late get after the 15s wait could beat native completion and surface as internal-error. Missing ids stay internal-error; dispose stays aborted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS
runTransactionwas returning a retryable FirestoreDeadlineExceededafter the 15s JS-bridge wait. The SDK retried, and a leftovertransactionGetDocumenthitEnsureCommitNotCalled.Fail that wait with a non-
FIRFirestoreErrorDomaintimeout so the SDK does not retry. That is required with this design:prepareresets get eligibility, so a retry would make a leftover JS get look live on the nextFIRTransaction. Android still throws retryableDEADLINE_EXCEEDED, so the same slowupdateFunctionfails once on iOS and keeps retrying on Android.deadline-exceeded(orabortedif disposed). A missing id still rejectsinternal-error. Leftover applyBuffer is a no-op.applyBuffer/ a second reject once the id is already finishedMaintainer note: Fixes internal CPRN-426