Repository navigation
bug: componentProps of modalController does not work with Angular 17.1.0 signal inputs #28876
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v7.x
Current Behavior
Passing componentProps (when using a modalController) throws an error when the input of the component is a signal (Input signals are a feature of Angular 17.1.0).
Expected Behavior
The componentProps should work even if the component input is a signal.
Steps to Reproduce
- Create a component to pass to a modalController which has signal inputs.
- Create a modal controller with componentProps that correspond to the component's input signals.
- Open the modal and observe the results with dismay.
Code Reproduction URL
https://github.com/ntorrey/ionbug
Ionic Info
Ionic:
Ionic CLI : 7.2.0
Ionic Framework : @ionic/angular 7.6.6
@angular-devkit/build-angular : 17.1.1
@angular-devkit/schematics : 17.1.1
@angular/cli : 17.1.1
@ionic/angular-toolkit : 11.0.0
Capacitor:
Capacitor CLI : not installed
@capacitor/android : not installed
@capacitor/core : not installed
@capacitor/ios : not installed
Utility:
cordova-res : not installed globally
native-run : not installed globally
System:
NodeJS : v18.18.0 (C:\Program Files\nodejs\node.exe)
npm : 10.4.0
OS : Windows 10
Additional Information
No response
Activity
liamdebeasi commentedon Jan 25, 2024
Thanks! Here's a dev build with a fix:
7.6.2-dev.11706205501.196a5433Note that this is an Ionic 8 build and is subject to breaking changes.
ntorrey commentedon Jan 26, 2024
Seems to work now - thanks for the quick response!
liamdebeasi commentedon Jan 26, 2024
Thanks for testing! I'm going to keep this open until the linked PR is merged.
EinfachHans commentedon Apr 25, 2024
Just mentioned it has not been included in v8?
liamdebeasi commentedon Apr 25, 2024
No, the PR has not been merged.
SadraRahmani commentedon Apr 28, 2024
feat(angular): setting props on a signal works (#29453)
ntorrey commentedon May 9, 2024
Woohoo! Can't wait for the 8.2 release. It will be good to finally move off of the dev version I've been using (not in production of course 😬). Thanks for your work on this!
sean-perkins commentedon May 9, 2024
Thanks for reporting this issue! This has been resolved with #29453 and will be available in the next minor release 🎉
sean-perkins commentedon May 22, 2024
👋 this is now available in v8.2.0. Upgrade your apps and let us know if you experience any issues!
Edit:
This feature is opt-in, so be sure to update your Ionic config to include:
muuvmuuv commentedon May 22, 2024
Works! Thanks :)
ionitron-bot commentedon Jun 21, 2024
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
ModalControlleris not compatible with Angular signal inputs #30784 as a duplicate of this issue