Repository navigation

fix(modal): focus the dialog wrapper on present so screen readers can enter the modal - #31260

Merged

gnbm merged 26 commits into

mainfrom

FW-7611_investigation

Jul 17, 2026

Merged

fix(modal): focus the dialog wrapper on present so screen readers can enter the modal#31260
gnbm merged 26 commits into
mainfrom
FW-7611_investigation

Commits on Jul 1, 2026
Commits on Jul 2, 2026
- Update comment in modal
  gnbm
  authored
  cbca643
Commits on Jul 7, 2026
- Update core/src/components/modal/test/a11y/modal.e2e.ts
  
  gnbm
  and
  brandyscarney
  authored
  fe89761
- Update core/src/components/modal/modal.tsx
  
  gnbm
  and
  brandyscarney
  authored
  ca26b3b
- fix(modal): focus the dialog wrapper on present for sheet and card modals too
  gnbm
  committed
  b1ca7aa
Commits on Jul 8, 2026
Commits on Jul 13, 2026
- Update core/src/components/modal/modal.scss
  
  gnbm
  and
  brandyscarney
  authored
  481e513
- Update core/src/components/modal/test/a11y/modal.e2e.ts
  
  gnbm
  and
  brandyscarney
  authored
  03397f2
- Update core/src/utils/overlays.ts
  
  gnbm
  and
  brandyscarney
  authored
  870c497
- Update core/src/components/modal/test/a11y/modal.e2e.ts
  
  gnbm
  and
  brandyscarney
  authored
  0a1b6f3
- Update core/src/components/modal/test/a11y/modal.e2e.ts
  
  gnbm
  and
  brandyscarney
  authored
  2d3cb96
- Update core/src/components/modal/test/a11y/modal.e2e.ts
  
  gnbm
  and
  brandyscarney
  authored
  16d0939
- test(modal): address review feedback on a11y focus tests
  gnbm
  committed
  b0b5256
- fix(overlays): only retarget focus to a focusable dialog wrapper
  gnbm
  committed
  5ddc39c
- fix(overlays): guard preventScroll focus against engines that mishandle options
  gnbm
  committed
  7449639
Commits on Jul 16, 2026
- revert(modal): remove firefox specific workaround
  brandyscarney
  committed
  e949b3b
- style: lint and comments
  brandyscarney
  committed
  42aed23
- fix(modal): clear text selection on gesture start
  brandyscarney
  committed
  ec2f5d0
- test(playwright): update drag element to clear selection
  brandyscarney
  committed
  31cd99d

Navigation Menu

Repository navigation

fix(modal): focus the dialog wrapper on present so screen readers can enter the modal - #31260

fix(modal): focus the dialog wrapper on present so screen readers can enter the modal#31260
gnbm merged 26 commits into
mainfrom
FW-7611_investigation

Commits on Jul 1, 2026

fix(overlays): focus the dialog wrapper, not the role-less host, on present

fix(overlays): only redirect present() focus to a wrapper that is actually focusable

fix(popover): add default role="dialog" so aria-modal is not a no-op

fix(modal): scope dialog-wrapper focus to default modals; keep host focus for sheet/card

revert(popover): drop default role="dialog"; keep PR scoped to modal fix

test(modal): use idiomatic toBeFocused for the a11y focus assertion

Commits on Jul 2, 2026

Update comment in modal

Commits on Jul 7, 2026

Update core/src/components/modal/test/a11y/modal.e2e.ts

Update core/src/components/modal/modal.tsx

fix(modal): focus the dialog wrapper on present for sheet and card modals too

Commits on Jul 8, 2026

fix(modal): suppress native focus ring on the focused wrapper

refactor(modal): simplify a11y fix comments and extend gesture guard coverage

docs(modal): trim verbose comments on the a11y focus fix

Commits on Jul 13, 2026

Update core/src/components/modal/modal.scss

Update core/src/components/modal/test/a11y/modal.e2e.ts

Update core/src/utils/overlays.ts

Update core/src/components/modal/test/a11y/modal.e2e.ts

Update core/src/components/modal/test/a11y/modal.e2e.ts

Update core/src/components/modal/test/a11y/modal.e2e.ts

test(modal): address review feedback on a11y focus tests

fix(overlays): only retarget focus to a focusable dialog wrapper

fix(overlays): guard preventScroll focus against engines that mishandle options

Commits on Jul 16, 2026

revert(modal): remove firefox specific workaround

style: lint and comments

fix(modal): clear text selection on gesture start

test(playwright): update drag element to clear selection