Repository navigation
fix(range): update knob positions when dualKnobs changes - #31365
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
HappyKnuckles
pushed a commit
to HappyKnuckles/ionic-framework
that referenced
this pull request
Oct 3, 2026
…31365) Issue number: resolves ionic-team#31026 --------- Opening an `ion-range` with `dualKnobs` set to `true` with a value set inside of a modal does not render the values properly. - Added a watcher for `dualKnobs` that calls `updateRatio()`, ensuring knob ratios are recomputed whenever `dualKnobs` changes. The `min`, `max`, and `value` properties already had watchers. `dualKnobs` was the only ratio-affecting property without one. - Knobs are now positioned correctly regardless of whether `value` or `dualKnobs` is assigned first. They are also repositioned correctly when `dualKnobs` is toggled at runtime in either direction. - Range now sets the correct values when used inside a modal, including when `dualKnobs` and `value` are assigned in different orders. - Improved the `dualKnobs` property description. - Added e2e tests covering both property assignment orders and runtime toggling of `dualKnobs`. - [ ] Yes - [x] No --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com> Co-authored-by: pratyushjaiswal0806-dot <pratyushjaiswal0806@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31026
What is the current behavior?
Opening an
ion-rangewithdualKnobsset totruewith a value set inside of a modal does not render the values properly.What is the new behavior?
dualKnobsthat callsupdateRatio(), ensuring knob ratios are recomputed wheneverdualKnobschanges. Themin,max, andvalueproperties already had watchers.dualKnobswas the only ratio-affecting property without one.valueordualKnobsis assigned first. They are also repositioned correctly whendualKnobsis toggled at runtime in either direction.dualKnobsandvalueare assigned in different orders.dualKnobsproperty description.dualKnobs.Does this introduce a breaking change?
Other information
Preview