Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
added this pull request to stack #31538
October 6, 2026 22:11
thetaPC
marked this pull request as ready for review
October 12, 2026 18:13
brandyscarney
approved these changes
Oct 15, 2026
Member
There was a problem hiding this comment.
Does the theme also need to be added to generator.ts:
Contributor
Author
There was a problem hiding this comment.
Not for this PR. The base theme is for checking migrated components by hand without a theme, and no spec runs it in Playwright yet. When one should screenshot it, the generator needs base-ios and base-md modes and 'base' in Theme, since it splits the mode string into theme and mode.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Test pages accept
ionic:themevalues ofionic,iosandmdonly. Any other value falls back tomd, so there is no way to see how a migrated component renders without a theme.What is the current behavior?
ionic,iosandmdthemes. Withionic:theme=base, no tokens load, so palettes such as dark don't apply and there's no way to see how a migrated component renders with only the base tokens.Does this introduce a breaking change?
Other information
Open each before and after link side by side.