Repository navigation
refactor(gallery-item): migrate to modular theming - #31606
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
added this pull request to stack #31613
October 20, 2026 19:28
brandyscarney
marked this pull request as ready for review
October 20, 2026 19:50
thetaPC
approved these changes
Oct 22, 2026
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
One thing outside this diff: the uniform layout uses aspect-ratio (gallery-item.scss), which needs Firefox 89. v10 still has to work on v9's browser floors (Firefox 75), so on Firefox 75 to 88 the uniform cells lose their square shape. Please add a fallback for browsers without it, for example a padding-based square inside @supports not (aspect-ratio: 1 / 1), either here or in a follow-up for the gallery family.
Member
Author
brandyscarney
force-pushed
the
FW-7286-gallery-item
branch
from
October 23, 2026 14:18
5031658 to
d77fea8
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ion-gallery-itemreads the theme and adds it as a class on its host, but none of its styles depend on the theme.What is the new behavior?
ion-gallery-itemto Modular Ionic: removes thethemevirtual prop and the theme class on the host.api.txt,components.d.tsand the Angular proxies, which drop thethemeinput.Does this introduce a breaking change?
ion-gallery-itemhasn't been in a release yet, so removingthemeisn't breaking.Other information
How to test
<figure>line up with the others and keep the same size.Swap
ionic:themeandionic:modetoiosormdto check the other themes.