Repository navigation
Conversation
|
@rdlabo is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Sorry for opening this PR before narrowing the scope sufficiently. The change reaches into modal animations and gestures, which is too broad for the original visual issue. I am closing it to reconsider a smaller approach. Apologies for the unnecessary review overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: rdlabo-dev/ionic-theme-ios27#269
What is the current behavior?
iOS sheet modals meet the side and bottom edges of the viewport at partial breakpoints. CSS alone cannot keep an inset sheet's visible bounds and rounded lower corners synchronized with interactive dragging and breakpoint transitions.
Independent iOS 27.0 simulator measurements show that native iPhone sheets have side and bottom gaps at partial detents and return to full width at the large detent. iPad uses a different presentation policy.
What is the new behavior?
--sheet-insetfor iOS sheet modals. Partial detents scale and clip the sheet with side/bottom gaps and rounded lower corners; breakpoint 1 returns to full width. The default is zero and MD is unchanged.Applications choose when to enable this property. It does not automatically identify devices or claim exact native spring or detent-height parity; existing Ionic breakpoint height semantics are retained.
Does this introduce a breaking change?
Other information
Validation: