Repository navigation
fix(overlays): do not blur focused element on present when keyboardClose is false - #31644
Open
ShryukGrandhi wants to merge 1 commit into
Conversation
…ose is false Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31199
What is the current behavior?
When an overlay is presented,
restoreElementFocusblurs the currently focused element unconditionally, beforekeyboardCloseis checked anywhere. So anion-popoverwithkeyboard-close="false"opened while a text input is focused still takes focus away from the input, and on mobile the keyboard closes. This started in 8.7.4 when the blur was added to prevent an a11y warning.What is the new behavior?
restoreElementFocusonly blurs the previously focused element when the overlay'skeyboardCloseis notfalse. The element is still remembered so focus is restored on dismiss.keyboardClosetrue) is unchanged.ion-popoverchecking that the focused input is not blurred on present withkeyboardClose={false}and still is withkeyboardClose={true}.Does this introduce a breaking change?
Other information
Fixes #31199
Tested with
npx stencil test --specincore(new test fails before the change, all 812 spec tests pass after), plus eslint and prettier on the touched files.